[wifi_remote]: Make flat version structure across IDF releases #660
Conversation
david-cermak
force-pushed
the
feat/wifi_remote_flat
branch
2 times, most recently
from
8852995
to
b0f8e88
Compare
|
@euripedesrocha @mantriyogesh PTAL at this proposal, I'd like to continue with linear versioning of wifi-remote (and replace #644 #643 with this one) still need to cleanup commit history and build related IDF examples. |
| @@ -0,0 +1,432 @@ | |||
| /* | |||
There was a problem hiding this comment.
I sense the directory stricture being modified and the esp_wifi_remote_weak.c moved inside of idf. Any changes from application/hosted side needed for this?
There was a problem hiding this comment.
Any changes from application/hosted side needed for this?
No change should be necessary, as the paths have been updated in CMake as well, so all headers are still available from public path (locations of sources shouldn't cause any trouble)
| @@ -1,3 +1,4 @@ | |||
| CONFIG_ESP_WIFI_REMOTE_LIBRARY_EPPP=y | |||
There was a problem hiding this comment.
do we still wish to use eppp as default solution here?
There was a problem hiding this comment.
I would still keep eppp as default for this example (since I wanted to build it with wifi capable chips as well, which doesn't seem to work with esp-hosted)
david-cermak
force-pushed
the
feat/wifi_remote_flat
branch
4 times, most recently
from
6e0e095
to
ab15807
Compare
|
LGTM.. |
rather than git history, as it might now work in GitHub CI (due to shallow cloning)
Rather than keeping sdkconfig.ci.*** for the smoke tests in git
Building also standard IDF examples that use esp-wifi-remote (building for wifiless targets ESP32P4, ESP32H2 and one wifi target ESP32s3)
IDF_VERSION_MAJOR, IDF_VERSION_MAJOR, rather than environmental variable {ESP_IDF_VERSION}
david-cermak
force-pushed
the
feat/wifi_remote_flat
branch
from
ab15807
to
c454ec0
Compare
Adds multiple IDF release branch support to a single version of
wifi-remoteto simplify release workflow of this componentesp_wifi_remoteis used